plugin_proxy: allow metrics type for output plugin proxy #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracewehner
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
I have a PR for the fluent-bit-go repo fluent/fluent-bit-go#79 that decodes and uses the metric type. It depends on the PR in this repo for metrics to be allowed to flow to the output plugin. |
Previously, the output plugin proxy supported only logs types as this is the default if no event_type is specified. This allows the metrics type to also be routed to output proxy plugins such as the golang proxy plugin. Signed-off-by: Grace Wehner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the fluent-bit metrics type to be routed to output proxy plugins such as the golang proxy plugin.
Currently the
proxy output pluginregistration does not include theout->event_typesetting for what types it accepts:fluent-bit/src/flb_plugin_proxy.c
Lines 364 to 370 in faf7da1
For output plugins that have no value for
event_type, those plugins default to supporting only the logs datatype:fluent-bit/src/flb_output.c
Lines 605 to 607 in faf7da1
The
fluent-bit routerwill enforce datatypes between input and output plugins and drop any data that has the type mismatch:fluent-bit/src/flb_task.c
Lines 435 to 438 in faf7da1
Addresses fluent/fluent-bit-go#75, fluent/fluent-bit-go#77
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1531
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.